ekurzinger marked an inline comment as done. ekurzinger added a comment.
In D18824#448597 <https://phabricator.kde.org/D18824#448597>, @romangg wrote: > In the first revision the interface failed to create when the dynamically loaded library was not present (we said the class should always be created though). Now it just fails silently on bind. Why is it ok to fail silently on bind? In D18824#448755 <https://phabricator.kde.org/D18824#448755>, @davidedmundson wrote: > > Now it just fails silently on bind. Why is it ok to fail silently on bind? > > We wouldn't get that far. > If the library didn't load then we wouldn't have sent an interface to wl_global_create > > I don't know how that behaves, but we would have either crashed already (which might warrant a guard in Global::Private::create) or the client wouldn't be seeing a global registered to bind to Actually, that was an oversight on my part. It looks like wl_global_create() doesn't actually check whether the interface is null, so right now it'll just segfault if the library can't be loaded. Probably not what we want. I'm re-working it right now to load the library in create() and bail out there if it's not successful to avoid this. I'll update the diff shortly. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18824 To: ekurzinger, romangg, davidedmundson, #kwin Cc: ngraham, mati865, schernikov, guilhermesi, kde-frameworks-devel, michaelh, bruns
