dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
The added signal seems fine to me. Much less black magic than an event filter
(which would have been the other option).
INLINE COMMENTS
> kdiroperator.h:916
> + /**
> + * Triggered when the user hit Enter/Return
> + */
Missing @since 5.57
> kfilewidgettest_gui.cpp:30
>
> - KFileWidget* fileWidget = new
> KFileWidget(QUrl(QStringLiteral("kfiledialog:///OpenDialog")), nullptr);
> - fileWidget->setMode(KFile::Files | KFile::ExistingOnly);
> + QApplication *ptr_app = &app;
> +
This bit is what's non-idiomatic, IMHO.
Why not capture app by reference?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D19824
To: meven, #frameworks, #dolphin, ngraham, dfaure
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
