meven added a comment.
In D19824#434053 <https://phabricator.kde.org/D19824#434053>, @ngraham wrote: > Makes sense, thanks. This fix works and looks sane to me. > > Maybe wait until at least one more #dolphin <https://phabricator.kde.org/tag/dolphin/> and/or #frameworks <https://phabricator.kde.org/tag/frameworks/> person has reviewed before committing, though. I still lack a bit experience with Qt, and my solution feels a bit overkill : listening to key Press and emitting a specific event. I could be missing a more idiomatic way to do this. I'd very much appreciate a second review. At least now the issue at hand is evident. I think I will clean up the test code a bit. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D19824 To: meven, #frameworks, #dolphin, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns
