cullmann added a comment.
Hi, sorry that I didn't look earlier at this ;=) I think in principle, that goes into the right direction. For more compile-time safety I would like to have enums. For the internal design: I would use the QVariant types and I would avoid that explicit isGlobal/local stuff in favor of a parent pointer. I will hand in an altered variant as an extra diff, then we can converge. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18894 To: loh.tar, cullmann, dhaumann Cc: mwolff, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
