dhaumann added a subscriber: mwolff. dhaumann added a comment.
This approach spreads they key "Word Wrap Column" across many files. You have to know the key and avoid typos. Currently we have this hard-coded and therefore statically checked by the compiler, which is very good. In grneral, I am not against the string based approach in addition to a statically checked approach. The string based setter then would take a QVariant as value. This way, we would also be close to the KTextEditor::ConfigInterface and could have a KTextEditor::Command 'set', i.e. F7: set word-wrap-column 80. @mwolff Didn't you once propose a template based approach to this? I have the feeling there are better solutions that perform just as well. Other comments? PS: yes, currently we have to write a lot of boilerplate code, but this is simple, the code is fast, and the functions are compile time checked. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18894 To: loh.tar, cullmann, dhaumann Cc: mwolff, kwrite-devel, kde-frameworks-devel, #ktexteditor, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
