bruns added inline comments. INLINE COMMENTS
> polkitqt1-authority.cpp:130 > + * The returned pointer needs to be freed via g_object_unref when no > + * longer needed. Returns NULL if details is empty. > + */ nullptr > polkitqt1-authority.cpp:328 > + if ( details.empty() ) > + return NULL; > + nullptr > polkitqt1-authority.cpp:332 > + > + for ( const auto &entry: details.toStdMap() ) { > + const auto &key = entry.first; whitespace > polkitqt1-authority.cpp:422 > + > + if (pk_details != NULL) { > + g_object_unref(pk_details); nullptr, or just `if (pk_details) {` > polkitqt1-authority.h:226 > + */ > + void checkAuthorizationWithDetails( > + const QString &actionId, const Subject &subject, please add a KF6 TODO, merge with checkAuthorization REPOSITORY R563 Polkit-1 Qt Library REVISION DETAIL https://phabricator.kde.org/D18845 To: mgerstner, #frameworks, chinmoyr, fvogt, bruns Cc: kde-frameworks-devel