chinmoyr added a comment.
I would like this patch to land so +1 from me. But I am not familiar with this code so I can't give any meaningful feedback. Sorry. INLINE COMMENTS > polkitqt1-authority.cpp:336 > + > + polkit_details_insert(ret, key.toUtf8().data(), > value.toUtf8().data()); > + } Nitpick; constData() because the API seems to take const gchar* REVISION DETAIL https://phabricator.kde.org/D18845 To: mgerstner, #frameworks, chinmoyr, fvogt, bruns Cc: mati865, kde-frameworks-devel
