astippich created this revision. astippich added reviewers: ngraham, bruns, mgallien. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision.
REVISION SUMMARY Rewrite the taglib extractor to use taglib's PropertyMap. Since this largely unifies the handling of the different tag formats, but not quite, a lot of code is removed. The resulting code is also faster. Additionally, this avoids the usage of a FileRef object, which fixes a potential crash due to a known bug in taglib. BUG: 403902 REPOSITORY R286 KFileMetaData BRANCH rewrite_taglib_extractor REVISION DETAIL https://phabricator.kde.org/D18826 AFFECTED FILES src/extractors/taglibextractor.cpp src/extractors/taglibextractor.h To: astippich, ngraham, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
