elvisangelaccio added inline comments. INLINE COMMENTS
> kbuildsycocaprogressdialog.cpp:71 > setAutoClose(false); > + QDialogButtonBox* dialogButtonBox = new > QDialogButtonBox(QDialogButtonBox::Cancel); > + setCancelButton(dialogButtonBox->button(QDialogButtonBox::Cancel)); Please also pass `this` as parent, otherwise the button box will leak. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17281 To: GB_2, ngraham, #frameworks, cfeck Cc: elvisangelaccio, ngraham, kde-frameworks-devel, alexde, IohannesPetros, trickyricky26, michaelh, crozbo, ndavis, firef, bruns, skadinna, aaronhoneycutt, mbohlender
