ngraham accepted this revision. ngraham added reviewers: Frameworks, cfeck. ngraham added a comment. This revision is now accepted and ready to land.
Works and seems reasonable enough. Anyone else have any opinions on the matter? Also @gb_2, please provide your real name and email address so we can land this patch with correct authorship information. If you use `arc` for your next patch (https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist), we won't have to nag you like this. :) Also in the future, populating the Test Plan section can make life easier for your reviewer. In this case, something as simple as "open KMenuEdit, change something, and click save" would be nice. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17281 To: GB_2, ngraham, #frameworks, cfeck Cc: ngraham, kde-frameworks-devel, alexde, IohannesPetros, trickyricky26, michaelh, crozbo, ndavis, firef, bruns, skadinna, aaronhoneycutt, mbohlender
