anthonyfieroni added inline comments.
INLINE COMMENTS
> kglobalaccel_x11.cpp:198-208
> +typedef union {
> + /* All XKB events share these fields. */
> + struct {
> + uint8_t response_type;
> + uint8_t xkbType;
> + uint16_t sequence;
> + xcb_timestamp_t time;
I see what you doing, but don't do it. See below.
> kglobalaccel_x11.cpp:233
> + if(m_xkb_first_event && responseType == m_xkb_first_event) {
> + _xkb_event *xkb_event = reinterpret_cast<_xkb_event*>(event);
> + switch (xkb_event->any.xkbType) {
Cast to xcb_generic_event_t
> kglobalaccel_x11.cpp:234
> + _xkb_event *xkb_event = reinterpret_cast<_xkb_event*>(event);
> + switch (xkb_event->any.xkbType) {
> + case XCB_XKB_MAP_NOTIFY:
Use pad0 (stupid name but you can get it as ref and name as you want)
> kglobalaccel_x11.cpp:239
> + case XCB_XKB_NEW_KEYBOARD_NOTIFY: {
> + xcb_xkb_new_keyboard_notify_event_t *ev =
> &xkb_event->new_keyboard_notify;
> + if (ev->changed & XCB_XKB_NKN_DETAIL_KEYCODES)
Cast event to xcb_xkb_new_keyboard_notify_event_t.
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D16434
To: fvogt, #frameworks, #plasma
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns
