astippich added inline comments.

INLINE COMMENTS

> bruns wrote in epubextractor.cpp:44
> The idea behind using anonymous namespaces is to neither "pollute" the class 
> namespace nor the global namespace. Remove the "EPubExtractor::" qualifier, 
> see `fetchMetadata`.

All the stringlists are currently implemented as a private static member of the 
class... would you like to change that to a local static variable?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16554

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

Reply via email to