bruns added inline comments.

INLINE COMMENTS

> epubextractor.cpp:44
>  {
> +const QStringList EPubExtractor::mMimetypes = {
> +    QStringLiteral("application/epub+zip"),

The idea behind using anonymous namespaces is to neither "pollute" the class 
namespace nor the global namespace. Remove the "EPubExtractor::" qualifier, see 
`fetchMetadata`.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16554

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

Reply via email to