pino requested changes to this revision.
pino added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kcolorschememanager.cpp:52
> + QAction *const resetAction = new
> QAction(index.data(Qt::DecorationRole).value<QIcon>(),
> + i18n("Default
> (%0)").arg(systemScheme),
> + menu);
- not the correct way to pass arguments to i18n -- they are extra parameters to
the i18n function itself
- even if %0 is supported, usually the first argument is %1
> kcolorschememanager.h:127
> + */
> + KActionMenu *createSchemeSelectionMenuWithDefaultEntry(const QIcon
> &icon, const QString &text, const QString &selectedSchemeName, QObject
> *parent);
> +
instead of a custom variant, what about creating new versions of the
`createSchemeSelectionMenu` functions that take flags instead?
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D15645
To: amhndu, #frameworks, broulik, cfeck, elvisangelaccio, ngraham, pino
Cc: pino, ngraham, broulik, kde-frameworks-devel, michaelh, bruns
