ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
Doesn't build for me:
[ 51%] Building CXX object
tests/CMakeFiles/kcodecactiontest.dir/kcodecactiontest.cpp.o
/home/dev/repos/kconfigwidgets/tests/kcolorschemedemo.cpp: In constructor
‘KColorSchemeDemo::KColorSchemeDemo()’:
/home/dev/repos/kconfigwidgets/tests/kcolorschemedemo.cpp:46:34: error:
‘class KColorSchemeManager’ has no member named
‘createSchemeSelectionMenuWithDefault’; did you mean
‘createSchemeSelectionMenuWithDefaultEntry’?
button->setMenu(manager->createSchemeSelectionMenuWithDefault({},
{}, {}, button)->menu());
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
createSchemeSelectionMenuWithDefaultEntry
[ 53%] Building CXX object
tests/CMakeFiles/kcodecactiontest.dir/kcodecactiontest_autogen/mocs_compilation.cpp.o
INLINE COMMENTS
> kcolorschemedemo.cpp:46
> button->setIcon(QIcon::fromTheme(QStringLiteral("fill-color")));
> -
> button->setMenu(manager->createSchemeSelectionMenu(QStringLiteral("Oxygen"),
> button)->menu());
> + button->setMenu(manager->createSchemeSelectionMenuWithDefault({},
> {}, {}, button)->menu());
> +
Needs to be `createSchemeSelectionMenuWithDefaultEntry`
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D15645
To: amhndu, #frameworks, broulik, cfeck, elvisangelaccio, ngraham
Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns
