bruns accepted this revision.
bruns added a comment.
This revision is now accepted and ready to land.


  Otherwise good to go ...

INLINE COMMENTS

> taglibwritertest.cpp:75
> +    // source encoding: "€µ"
> +    static const QChar data[4] = { 0x20ac, 0xb5 };
> +    QString unicodeTestStringSuffix(data, 2);

can you change this to `data[2]` ...
Facepalm myself ...

REPOSITORY
  R286 KFileMetaData

BRANCH
  taglib_write_unicode

REVISION DETAIL
  https://phabricator.kde.org/D15714

To: astippich, mgallien, bruns
Cc: smithjd, svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

Reply via email to