bruns added a comment.
In D15939#337534 <https://phabricator.kde.org/D15939#337534>, @poboiko wrote: > As for symlinked folders - I once looked into, a year ago or so. As far as I remember, those can be really tricky (but I don't really remember all the details): > > - There might be duplicated entries in index pointing to same file, which doesn't look good - if we index the same folder twice (symlink and original; but I guess we can always rely on `resolved` path, which should be unique - apart from hard links?) > - There might be recursive symlinks / loops, which should be handled (i.e. `dir1/subdir -> dir2` and `dir2/subdir -> dir1/`; but it looks like `QDirIterator` can handle symlink loops?) > - There might be a symlink to a folder, which has some parent excluded from indexing > - ...and maybe more > > I'll see if there is something not easily manageable. Adding to all the points you already mentioned, I am also against following symlinks: - if a symlink points inside a hierarchy already included, there is nothing gained - if a symlink points outside, it can be included explicitly using includeFolders Prior to any implementation attempt I would like to see a specific use case for following symlinks, which is not already covered. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15939 To: poboiko, #baloo, #frameworks, vhanda, ngraham Cc: bruns, ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, abrahams
