poboiko added a comment.
In D15939#337418 <https://phabricator.kde.org/D15939#337418>, @ngraham wrote: > Works great, thanks for all these Baloo patches! They are very much appreciated. Code looks good. As with the others, please commit for Frameworks 5.52. > > While you're cranking away at these, might I suggest a few others that are sorely needed: > > - No apparent effect after removing a folder from the index; need to restart or kill all Baloo processes: https://bugs.kde.org/show_bug.cgi?id=373430 & https://bugs.kde.org/show_bug.cgi?id=353559 I can look at these, shouldn't be too hard. > - Baloo doesn't index or search symlinked folders: https://bugs.kde.org/show_bug.cgi?id=362226 I guess this link also should be added to previous two :) As for symlinked folders - I once looked into, a year ago or so. As far as I remember, those can be really tricky (but I don't really remember all the details): - There might be duplicated entries in index pointing to same file, which doesn't look good - if we index the same folder twice (symlink and original; but I guess we can always rely on `resolved` path, which should be unique - apart from hard links?) - There might be recursive symlinks / loops, which should be handled (i.e. `dir1/subdir -> dir2` and `dir2/subdir -> dir1/`; but it looks like `QDirIterator` can handle symlink loops?) - There might be a symlink to a folder, which has some parent excluded from indexing - ...and maybe more I'll see if there is something not easily manageable. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15939 To: poboiko, #baloo, #frameworks, vhanda, ngraham Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams
