leinir updated this revision to Diff 42360. leinir added a comment.
Address @cfeck's comments REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6513?vs=41886&id=42360 REVISION DETAIL https://phabricator.kde.org/D6513 AFFECTED FILES autotests/knewstuffentrytest.cpp src/attica/atticaprovider.cpp src/core/CMakeLists.txt src/core/engine.cpp src/core/engine.h src/core/entryinternal.cpp src/core/entryinternal.h src/core/provider.cpp src/core/provider.h src/core/tagsfilterchecker.cpp src/core/tagsfilterchecker.h src/staticxml/staticxmlprovider.cpp tests/CMakeLists.txt tests/khotnewstuff_test-ui/main.qml tests/khotnewstuff_test-ui/main.qmlc tests/khotnewstuff_test.knsrc.in tests/knewstuff2_test.cpp tests/knewstuff2_test.h tests/knewstuff2_test.knsrc tests/testdata/entry.xml tests/testdata/provider.xml To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure, cfeck Cc: rikmills, dfaure, cfeck, mlaurent, ngraham, ahiemstra, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, bruns
