cfeck added a comment.
Using a hash to map public to private class is a good idea. The only thing
I'm not sure about is if there is a memory leak. I would think that having only
pointers in the hash will never free the referenced values.
INLINE COMMENTS
> provider.cpp:44
> + if (!ret)
> + {
> + ret = new ProviderPrivate;
Frameworks coding style:
if (...) {
...
}
> provider.cpp:51
> +
> +static void delete_d(const Provider* provider)
> +{
`* ` -> ` *`
> provider.cpp:54
> + if (auto d = d_func())
> + {
> + delete d->take(provider);
again
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D6513
To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure,
cfeck
Cc: rikmills, dfaure, cfeck, mlaurent, ngraham, ahiemstra,
kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, bruns
