bruns added inline comments. INLINE COMMENTS
> svuorela wrote in taglibwritertest.cpp:66 > I suggest checking that the last bytes of all these extracted things is the > actual actual utf8 bytes, so that if someone compiles or saves this file in a > broken encoding that the testing doesn't fail. ? The file/tags are written inside this test. > svuorela wrote in taglibwritertest.cpp:75 > Given stringSuffix is the same for all tests, is it needed to have as a test > data thing ? My idea here was to check each format twice, once with a simple latin1/ascii string (stringsuffix = "") and a second time with some unicode chars (e.g. "€", probably some more from other code blocks). This allows to differentiate if only unicode tags are broken. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15714 To: astippich, mgallien, bruns Cc: svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
