dfaure added a comment.
BTW, the commit message refers to ModelTest, but that's the old modeltest.cpp, not the new QAbstractItemModelTester, right? I'm working on QConcatenateTablesProxyModel (https://codereview.qt-project.org/166323) and there QAbstractItemModelTester passes with asserts for all these invalid calls. The old modeltest is now considered wrong ;) Not saying this commit should be reverted or anything, this is just to let you know about QAbstractItemModelTester and the fact that the new idea is narrow contract, asserting is good, while the old modeltest assumed very tolerant model implementations. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D13043 To: apol, #frameworks, broulik Cc: dfaure, broulik, kde-frameworks-devel, michaelh, ngraham, bruns
