apol marked 3 inline comments as done.
apol added inline comments.
INLINE COMMENTS
> broulik wrote in kconcatenaterowsproxymodel.cpp:112
> You can also use `{}` here, no? Also, I would prefer an early return rather
> than unary operator
No, the ternary operator doesn't allow using {} saying it can't infer the type.
Can change to an if.
> broulik wrote in kconcatenaterowsproxymodel.cpp:151
> Coding style. Also, check `parent.isValid() return {};` since this is a flat
> model?
why is it flat?
REPOSITORY
R275 KItemModels
REVISION DETAIL
https://phabricator.kde.org/D13043
To: apol, #frameworks
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns
