ngraham added inline comments. INLINE COMMENTS
> davidedmundson wrote in kcmtrash.cpp:303 > There's no benefit in changing the initial parent of these. > > It's all moot as QFormLayout::addItem takes ownership Ah right, I think I wrote this before I found that out. In fact, you can omit the parent entirely, so I think I'll do that. REPOSITORY R241 KIO BRANCH clean-up-trash-kcm (branched from master) REVISION DETAIL https://phabricator.kde.org/D12986 To: ngraham, #dolphin, #frameworks, #vdg, davidedmundson Cc: davidedmundson, abetts, rkflx, kfm-devel, kde-frameworks-devel, michaelh, ngraham, bruns