davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> kcmtrash.cpp:303
>
> - mLimitReachedAction = new QComboBox(mSizeWidget);
> - mLimitReachedAction->addItem(i18n("Warn Me"));
> + mLimitReachedAction = new QComboBox(this);
> + mLimitReachedAction->addItem(i18n("Show a Warning"));
There's no benefit in changing the initial parent of these.
It's all moot as QFormLayout::addItem takes ownership
REPOSITORY
R241 KIO
BRANCH
clean-up-trash-kcm (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D12986
To: ngraham, #dolphin, #frameworks, #vdg, davidedmundson
Cc: davidedmundson, abetts, rkflx, kfm-devel, kde-frameworks-devel, michaelh,
ngraham, bruns
