ngraham accepted this revision. ngraham added a comment.
The idea behind D12321 <https://phabricator.kde.org/D12321> was to increase buy-in, since one of the objections was that most previews are a useless regression at small icon sizes. Text files still won't be previewed by default at any size since we read from Dolphin's config file and they're off by default there. I feel pretty confident that with these two polish points, previews in the open/save dialogs are a clear win. Of course that's just my opinion! :) BRANCH preview_default (branched from master) REVISION DETAIL https://phabricator.kde.org/D12328 To: anemeth, #frameworks, #vdg, rkflx, ngraham Cc: elvisangelaccio, abetts, rkflx, ngraham, #frameworks, michaelh, bruns
