rkflx accepted this revision. rkflx added a subscriber: elvisangelaccio. rkflx added a comment. This revision is now accepted and ready to land.
LGTM now (even though you ignored the "newline" I suggested…) I'd appreciate a second opinion from #Frameworks <https://phabricator.kde.org/tag/frameworks/> on the new `kconf_update` directory, though. Also, the very idea of enabling previews by default in the file picker (as was done in Dolphin for 18.04) should get some more buy-in. I feel bad for tagging @elvisangelaccio again, but maybe you have suggestions for someone else who might help out in reviewing some of the patches for the file dialog? BRANCH preview_default (branched from master) REVISION DETAIL https://phabricator.kde.org/D12328 To: anemeth, #frameworks, #vdg, rkflx Cc: elvisangelaccio, abetts, rkflx, ngraham, #frameworks, michaelh, bruns
