sharvey added a comment.
In D12321#249568 <https://phabricator.kde.org/D12321#249568>, @anemeth wrote: > (effective screencast) +1 from me, and you beat me to it. 😃 I was just looking through the code when Thunderbird chimed that I had new mail. For the sake of clarification, the reason this works and my attempt in D12094 <https://phabricator.kde.org/D12094> did not, is because this `KToggleAction` is, for lack of a better term, unique. There's no second, competing Preview action to confuse the issue and be duplicated in Toolbar Preferences. You **can** bend a `KToggleAction` to your will; that's pretty straightforward. As you can see in @anemeth's patch, toggling it on or off (or disabling it entirely) is just a matter of setting the right flags, under the desired conditions. My work in D12094 <https://phabricator.kde.org/D12094> does much of the same, but because we were trying to implement two closely-related Find actions, we needed two action entries. Here, we only need one. And because there's just one to worry about, Alex can make it do any trick he wants, without worrying about interfering with or getting confused with another action item. I think this effect is subtle but very classy and polished. We show previews at higher sizes by default, but they can be toggled on or off at any time. The Preview button is disabled at tiny sizes, because it makes no sense otherwise. Looks good. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12321 To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin Cc: sharvey, rkflx, ngraham, #frameworks, michaelh, bruns
