rkflx added a comment.
In D12321#249441 <https://phabricator.kde.org/D12321#249441>, @ngraham wrote: > In D12321#249367 <https://phabricator.kde.org/D12321#249367>, @rkflx wrote: > > > The relation between the Preview and the Zoom slider is now a bit weird: You can override with the button, but once you move the slider the setting will be gone again. Also, when showing the dialog after closing it, the slider has preference over the button. In addition, even though the button says "enabled", users will wonder why no thumbnails are showing! > > > > Would it make sense to both: > > > > - Set the button state to "off" once the icons are too small, to make it clear that no previews are to be expected. > > - Disable the button, so manually toggling thumbnails only works if icons are big enough. > > > Something like this might be nice, but as you observed, it'll get real complicated real fast. And as @sharvey discovered in D12094 <https://phabricator.kde.org/D12094>, trying to coerce a KToggleAction into doing something it doesn't want to do can be daunting. As far as I can see, those are two totally separate issues. Here we should be able to disable the complete action (second point), and toggle the thumbnails via the action instead of sidestepping it (first point). > My vote gots to disabling the button at small sizes, if that's easily possible. There is nothing to vote on. Both points should be implemented. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12321 To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin Cc: sharvey, rkflx, ngraham, #frameworks, michaelh, bruns
