michaelh added inline comments.

INLINE COMMENTS

> mlaurent wrote in main.cpp:135
> very hard to read it.
> Could you split in several QString so it will more easy to check it's if ok :)

I had trouble myself :)

> main.cpp:161
> +                         i18n("(c) 2018, Michael Heidelbach"));
> +    aboutData.addAuthor(i18n("Michael Heidelbach"), i18n("Maintainer"), 
> QStringLiteral("ottw...@gmail.com"));
> +    KAboutData::setApplicationData(aboutData);

To point this out. I'm **not** the maintainer of baloo. Maybe better remove 
this?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11287

To: michaelh, #baloo, #frameworks, mlaurent
Cc: mlaurent, ngraham, ashaposhnikov, michaelh, astippich, spoorun, 
nicolasfella, alexeymin

Reply via email to