kossebau added inline comments.

INLINE COMMENTS

> apol wrote in KF5PackageMacros.cmake:27
> How about if(KF5Plasma_FIND_VERSION VERSION_LESS 5.43.0)?
> 
> This way it's only shown on projects that are actually depending on the new 
> version. And if they are well then that's fine to have the warning.

This won't have any effect, given this will be always true for people which use 
this version as it is coming with all the other KF5 modules, no?

The problem is this:
as applet developer you have no choice but to use `plasma_install_package`. And 
you have no control about what it is doing, e.g. that it is using this other 
macro which spits out the warning.  So the package-system developers internal 
reminder to complete this task gets written out to all the other developers, 
who just innocently use this macro.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D11129

To: kossebau, mart, apol
Cc: #frameworks, michaelh

Reply via email to