apol added inline comments.

INLINE COMMENTS

> KF5PackageMacros.cmake:27
> +   # allow plasma_install_package to disable the warning until it is ported 
> away from this
> +   if (NOT ARGV4 STREQUAL NO_DEPRECATED_WARNING)
> +      message(AUTHOR_WARNING "Deprecated: use 
> kpackage_install_bundled_package")

How about if(KF5Plasma_FIND_VERSION VERSION_LESS 5.43.0)?

This way it's only shown on projects that are actually depending on the new 
version. And if they are well then that's fine to have the warning.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D11129

To: kossebau, mart, apol
Cc: #frameworks, michaelh

Reply via email to