aacid added a comment.
In https://phabricator.kde.org/D8964#173472, @dhaumann wrote: > In general this patch should be OK. > Could you try with Kate search warp behavior as well? KTextEditor relies on correct behaviors here heavily. What should i be looking at? that it appears and disappers correctly? Anything else specifically? INLINE COMMENTS > dhaumann wrote in kmessagewidgetautotest.cpp:32-40 > Hm, possibly an inline function instead of macros? inline function sucks here because when it fails it gives you the line number of the inline function instead of the line it actually fails in the test. > anthonyfieroni wrote in kmessagewidget.cpp:348 > Those it should be > > setFixedHeight(sizeHint().height()); I'm 99% sure it's the same value but since i'm comparing against content->height() in the if it makes more sense logically to set to the same value, why do you think sizeHint is better? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8964 To: aacid, #frameworks Cc: ngraham, dhaumann, anthonyfieroni, #frameworks
