apol added inline comments.
INLINE COMMENTS
> apol wrote in kfileitem.cpp:559
> My thinking was that if the display name was set through the UDSEntry, one
> would want it to continue coming from a UDSEntry. e.g. if
> `file:///boring.txt` display name is `Magnificient Text File` and we change
> its url into `file:///boring2.txt` we would still want the same. Or we'd
> issue a new UDSEntry.
>
> I'm happy to change it to
>
> - if (!d->m_entry.contains(KIO::UDSEntry::UDS_DISPLAY_NAME)) {
> + if (!d->m_strName.isEmpty()) {
>
> It was my first approach in fact, it worked fine.
https://phabricator.kde.org/D8683
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8643
To: apol, #frameworks, davidedmundson
Cc: dfaure, ngraham
