apol added inline comments.
INLINE COMMENTS
> dfaure wrote in kfileitem.cpp:559
> Wouldn't it be safer to say if (!name.isEmpty()), for the actual bug you were
> experiencing?
>
> Otherwise I'm afraid that this commit breaks a number of things, like after
> renaming a file, the new name doesn't appear because the old "display name"
> still applies, or the documented use case for setName which is kfind wanting
> to display subdir/subsubdir/file.txt (same issue, UDS_DISPLAY_NAME would
> prevent that from working).
My thinking was that if the display name was set through the UDSEntry, one
would want it to continue coming from a UDSEntry. e.g. if `file:///boring.txt`
display name is `Magnificient Text File` and we change its url into
`file:///boring2.txt` we would still want the same. Or we'd issue a new
UDSEntry.
I'm happy to change it to
- if (!d->m_entry.contains(KIO::UDSEntry::UDS_DISPLAY_NAME)) {
+ if (!d->m_strName.isEmpty()) {
It was my first approach in fact, it worked fine.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8643
To: apol, #frameworks, davidedmundson
Cc: dfaure, ngraham
