ilic added inline comments. INLINE COMMENTS
> davidedmundson wrote in klocalizedstringtest.cpp:59 > Pretty sure it's fine. kactivities and kjs use them with no issue. Well, since no-one else complained either, guess it's ok. Easy to fix later if someone does complain. > ilic wrote in kcatalog.cpp:124 > Only read access is needed here, user QHash::value instead of > QHash::operator[]. Also the lock should be removed, now that only read access is used. > ilic wrote in kcatalog.cpp:151 > Also only read access needed. Also the lock should be removed. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D5208 To: davidedmundson, #frameworks, ilic Cc: ilic
