palokisa added a comment.
In https://phabricator.kde.org/D5521#103536, @apol wrote: > In https://phabricator.kde.org/D5521#103535, @palokisa wrote: > > > > Make them optional dependencies. > > > > What do you mean by this? > > > > > find_package(KF5Crash) #note there's no REQUIRED > if (KF5Crash_FOUND) > somethingsomething() > endif() > Why not give the packager/builder full control of what she/he wants to do and leave the decision to presence of `dev` package during the build process? IMO this is error prone. >>> What is `KF5::Service` used for? You don't seem to be `#ifdef` it. Maybe it's not needed at all? >> >> I don't know. I didn't investigate that.....I thought, it's some kind of "self-initializing" component and it is enough to link the library. > > I don't think it's the case for KService (it is for KCrash though). Please investigate (or wait for feedback). Then I believe, it's only some remnant, because it's not used anywhere in the code. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D5521 To: palokisa, graesslin, mck182 Cc: apol, #frameworks
