apol added a comment.

  In https://phabricator.kde.org/D5521#103535, @palokisa wrote:
  
  > > Make them optional dependencies.
  >
  > What do you mean by this?
  
  
  
  
    find_package(KF5Crash) #note there's no REQUIRED
    if (KF5Crash_FOUND)
        somethingsomething()
    endif()
  
  
  
  >> What is `KF5::Service` used for? You don't seem to be `#ifdef` it. Maybe 
it's not needed at all?
  > 
  > I don't know. I didn't investigate that.....I thought, it's some kind of 
"self-initializing" component and it is enough to link the library.
  
  I don't think it's the case for KService (it is for KCrash though). Please 
investigate (or wait for feedback).

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D5521

To: palokisa, graesslin, mck182
Cc: apol, #frameworks

Reply via email to