apol added inline comments. INLINE COMMENTS
> kossebau wrote in Android.cmake:188 > So gnustl_shared is required by Qt for Android? Any link for backing this up > which I could use to please curious people? I could not find anything when I > quickly searched, so this here seemed just some magic checking :) It's where the STL lives: https://developer.android.com/ndk/guides/cpp-support.html > kossebau wrote in Android.cmake:209 > This was just moved around (see l.167 before), as part of grouping things > together instead of interleaved setup (as also mentioed at end of summary > text). Am to be blamed for trying too many things in one review, even if > related, will see to keep things as simple as possible in the future. > > This was added in > https://phabricator.kde.org/R240:faedc8d01697ab1d573d5740f24e7279f4dba14f. > So it was now found this would not be needed? Which Qt versions would > `__ANDROID__` work with? @cordlandwehr , your commit to be defended here, > please tell :) I was introduced in Qt in 499f9b2abfabacd254e1b23566343ac20322eb48 back in September 2015. If you didn't add it, then just leave it as is... REPOSITORY R240 Extra CMake Modules BRANCH avoidHostLibsIncludesinAndroidToolchain REVISION DETAIL https://phabricator.kde.org/D3646 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, #frameworks, #gcompris, #minuet, apol, mutlaqja, sandsmark, nienhueser, cordlandwehr
