> On nov. 7, 2016, 3:22 après-midi, Aleix Pol Gonzalez wrote: > > Looks sensible to me, thanks! What are you planning to use it for? > > > > Can you push the patch?
we use kauth for some kcmodule in plasma flavor of manjaro (arch base distribution). and it's for modules like as install/remove kernels and all extra modules), video drivers, etc. and as it use pacman that need to run with root privilege) to download and install package from repositories, the default DBus timeout of 25 secondes cause problems. I don't have the rights to push into. - stephane ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128902/#review100684 ----------------------------------------------------------- On nov. 7, 2016, 3:21 après-midi, stephane cachemaille wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128902/ > ----------------------------------------------------------- > > (Updated nov. 7, 2016, 3:21 après-midi) > > > Review request for KDE Frameworks. > > > Bugs: 363200 > https://bugs.kde.org/show_bug.cgi?id=363200 > > > Repository: kauth > > > Description > ------- > > Add timeout property to Kauth::Action class to be able to change the timeout > in QDBusConnection::asyncCall > > > Diffs > ----- > > src/HelperProxy.h 96f4cf1 > src/backends/dbus/DBusHelperProxy.h 8f4254c > src/backends/dbus/DBusHelperProxy.cpp d2620ac > src/backends/fakehelper/FakeHelperProxy.h d0fb3f5 > src/backends/fakehelper/FakeHelperProxy.cpp a044ac6 > src/kauthaction.h 4e33366 > src/kauthaction.cpp 34f559d > src/kauthexecutejob.cpp 8b6e177 > > Diff: https://git.reviewboard.kde.org/r/128902/diff/ > > > Testing > ------- > > tested with and without using the new proporty in a kcm module where the > action takes more than the default 25s > > > Thanks, > > stephane cachemaille > >
