----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128902/#review100684 -----------------------------------------------------------
Ship it! Looks sensible to me, thanks! What are you planning to use it for? Can you push the patch? - Aleix Pol Gonzalez On Nov. 7, 2016, 3:21 p.m., stephane cachemaille wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128902/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2016, 3:21 p.m.) > > > Review request for KDE Frameworks. > > > Bugs: 363200 > https://bugs.kde.org/show_bug.cgi?id=363200 > > > Repository: kauth > > > Description > ------- > > Add timeout property to Kauth::Action class to be able to change the timeout > in QDBusConnection::asyncCall > > > Diffs > ----- > > src/HelperProxy.h 96f4cf1 > src/backends/dbus/DBusHelperProxy.h 8f4254c > src/backends/dbus/DBusHelperProxy.cpp d2620ac > src/backends/fakehelper/FakeHelperProxy.h d0fb3f5 > src/backends/fakehelper/FakeHelperProxy.cpp a044ac6 > src/kauthaction.h 4e33366 > src/kauthaction.cpp 34f559d > src/kauthexecutejob.cpp 8b6e177 > > Diff: https://git.reviewboard.kde.org/r/128902/diff/ > > > Testing > ------- > > tested with and without using the new proporty in a kcm module where the > action takes more than the default 25s > > > Thanks, > > stephane cachemaille > >
