----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128023/#review97006 -----------------------------------------------------------
Ship it! Makes sense. Please adjust the @since to 5.24 if you push today or 5.25 otherwise. - David Faure On May 26, 2016, 11:35 a.m., Elvis Angelaccio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128023/ > ----------------------------------------------------------- > > (Updated May 26, 2016, 11:35 a.m.) > > > Review request for KDE Frameworks and Matthew Dawson. > > > Repository: kconfig > > > Description > ------- > > We don't use anymore KActions, so both the function name and its > documentation should be updated in favor of QAction (though I chose to use > authorizeAction() because authorizeQAction() looks bad to me). > > > Diffs > ----- > > src/core/kauthorized.h d098823469b1c2e0ed7a23e0a245a6c6b8c59868 > src/core/kauthorized.cpp 993a5e863e9c541ab963e114ae3e3819a1bbf0ff > > Diff: https://git.reviewboard.kde.org/r/128023/diff/ > > > Testing > ------- > > Builds. All tests pass. > > > Thanks, > > Elvis Angelaccio > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
