----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128023/#review95822 -----------------------------------------------------------
-1 While it was errorneously ported to this action all over the place when it should not have been, KXmlGui actions and other menu and toolbar actions should still use the action/ prefix. - Kai Uwe Broulik On Mai 26, 2016, 11:35 vorm., Elvis Angelaccio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128023/ > ----------------------------------------------------------- > > (Updated Mai 26, 2016, 11:35 vorm.) > > > Review request for KDE Frameworks and Matthew Dawson. > > > Repository: kconfig > > > Description > ------- > > We don't use anymore KActions, so both the function name and its > documentation should be updated in favor of QAction (though I chose to use > authorizeAction() because authorizeQAction() looks bad to me). > > > Diffs > ----- > > src/core/kauthorized.h d098823469b1c2e0ed7a23e0a245a6c6b8c59868 > src/core/kauthorized.cpp 993a5e863e9c541ab963e114ae3e3819a1bbf0ff > > Diff: https://git.reviewboard.kde.org/r/128023/diff/ > > > Testing > ------- > > Builds. All tests pass. > > > Thanks, > > Elvis Angelaccio > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
