----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128043/#review95986 -----------------------------------------------------------
+1 src/notifybyaudio.cpp (line 58) <https://git.reviewboard.kde.org/r/128043/#comment64923> I wonder why this is in QApplication and not QGuiApplication, internally it just does: QMetaObject::invokeMethod(QGuiApplication::platformNativeInterface(), "beep"); So, perhaps we should do that, to avoid depending on QtWidgets/QApplication? src/notifybyaudio.cpp (line 63) <https://git.reviewboard.kde.org/r/128043/#comment64924> compare with QLatin1String src/notifybyaudio.cpp (lines 76 - 77) <https://git.reviewboard.kde.org/r/128043/#comment64925> Unrelated/Whitespace-only change - Kai Uwe Broulik On Mai 29, 2016, 4:15 nachm., René J.V. Bertin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128043/ > ----------------------------------------------------------- > > (Updated Mai 29, 2016, 4:15 nachm.) > > > Review request for KDE Software on Mac OS X and KDE Frameworks. > > > Repository: knotifications > > > Description > ------- > > This is a follow-up to discussion on the plasma-devel ML. When not running > under a Plasma session it would be preferable if generic alert sounds are > (can be) delivered using the default system sound. The easiest way to do that > is to call `QApplication::beep()` ; at least on OS X this will play the > user's selected alert sound. > > I have implemented this for now by assuming the existence of a virtual > (relative) `beep` sound file that always plays the default sound. > > In addition, this patch provides better warning feedback if a soundfile isn't > found (making it easier to figure out which alert is misconfigured), and will > play the sysbeep in that case (so that the alert doesn't go lost if it's > sound-only). > Finally, no Phonon::AudioOutput object is created until that is actually > required. > > > Diffs > ----- > > src/notifybyaudio.cpp 903e996 > > Diff: https://git.reviewboard.kde.org/r/128043/diff/ > > > Testing > ------- > > Works as expected on OS X 10.9.5 > > > Thanks, > > René J.V. Bertin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
