----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128043/ -----------------------------------------------------------
Review request for KDE Software on Mac OS X and KDE Frameworks. Repository: knotifications Description ------- This is a follow-up to discussion on the plasma-devel ML. When not running under a Plasma session it would be preferable if generic alert sounds are (can be) delivered using the default system sound. The easiest way to do that is to call `QApplication::beep()` ; at least on OS X this will play the user's selected alert sound. I have implemented this for now by assuming the existence of a virtual (relative) `beep` sound file that always plays the default sound. In addition, this patch provides better warning feedback if a soundfile isn't found (making it easier to figure out which alert is misconfigured), and will play the sysbeep in that case (so that the alert doesn't go lost if it's sound-only). Finally, no Phonon::AudioOutput object is created until that is actually required. Diffs ----- src/notifybyaudio.cpp 903e996 Diff: https://git.reviewboard.kde.org/r/128043/diff/ Testing ------- Works as expected on OS X 10.9.5 Thanks, René J.V. Bertin
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
