----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125570/ -----------------------------------------------------------
(Updated March 28, 2016, 4:14 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks, KDEPIM, Aleix Pol Gonzalez, and Laurent Montel. Changes ------- Submitted with commit 5a9193879ea5a779f2e8887c65c666d2f2721d3b by R. Harish Navnit to branch master. Repository: kde-dev-scripts Description ------- A lot of KABC classes are deprecated in KF5. The porting script only replaces kabc occurences to kcontacts, but overlooks if the class being used still exists in kcontact or not. This leads to a lot of compile time #include<> errors. I feel this should and can be avoided by modifying the script. Was this overlooked on purpose or did we just miss it out ? I've really no prior knowledge or experience of working with perl and I've tried to handle the above mentioned scenario, by manually checking for deprecated classnames and replacing them with a blank space or commenting them out. Diffs ----- kf5/convert-kabc-to-kcontacts.pl 321fdf2c92745a3aece8e66085994458720f9dfd Diff: https://git.reviewboard.kde.org/r/125570/diff/ Testing ------- Ran the script on the kopete codebase which uses deprecated classes like addressbook, stdaddressbook, resource etc. Works fine, but takes a bit of time to execute. Thanks, R.Harish Navnit
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
