> On March 26, 2016, 3:23 p.m., David Faure wrote: > > Looks good to me, although this could all be a single perl script instead > > of a bash script calling perl so many times ;) But that's unrelated to this > > commit. > > > > Also in its current form, it should be a .sh rather than a .pl ....
Yes, it makes sense for this to be a .sh. I'm behind a firewall, on my university's WiFi and as a result, I can't push(unless I tether via some other source, which is not always possible). Can you push it on my behalf, when you find the time ? Thanks. - R.Harish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125570/#review94011 ----------------------------------------------------------- On March 26, 2016, 12:31 p.m., R.Harish Navnit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125570/ > ----------------------------------------------------------- > > (Updated March 26, 2016, 12:31 p.m.) > > > Review request for KDE Frameworks, KDEPIM, Aleix Pol Gonzalez, and Laurent > Montel. > > > Repository: kde-dev-scripts > > > Description > ------- > > A lot of KABC classes are deprecated in KF5. The porting script only replaces > kabc occurences to kcontacts, but overlooks if the class being used still > exists in kcontact or not. This leads to a lot of compile time #include<> > errors. I feel this should and can be avoided by modifying the script. Was > this overlooked on purpose or did we just miss it out ? > > I've really no prior knowledge or experience of working with perl and I've > tried to handle the above mentioned scenario, by manually checking for > deprecated classnames and replacing them with a blank space or commenting > them out. > > > Diffs > ----- > > kf5/convert-kabc-to-kcontacts.pl 321fdf2c92745a3aece8e66085994458720f9dfd > > Diff: https://git.reviewboard.kde.org/r/125570/diff/ > > > Testing > ------- > > Ran the script on the kopete codebase which uses deprecated classes like > addressbook, stdaddressbook, resource etc. > Works fine, but takes a bit of time to execute. > > > Thanks, > > R.Harish Navnit > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
