> On März 28, 2016, 5:39 vorm., Matthew Dawson wrote: > > Much better! I don't think this should handle XDG* variables explicitly, > > as they won't be used on other platforms and may cause confusion there. On > > platforms using XDG* variables, Qt handles this for us internally. I > > opened issues accordingly below. Other then that, looks good to me.
But where does Qt handles these internally? At the moment Qt isn't doing this at all. If we don't respect XDG_*_Home it is a unexpected result for XDG conform desktops. Do you suggest to #ifdef the XDG handling? > On März 28, 2016, 5:39 vorm., Matthew Dawson wrote: > > autotests/kconfigtest.cpp, line 581 > > <https://git.reviewboard.kde.org/r/127462/diff/2/?file=454401#file454401line581> > > > > We unfortunately can't test XDG* variables due to Qt, but I think we'll > > be ok for now. The rest of the looks fine. Well the test is green, so this works :D - Sandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127462/#review94057 ----------------------------------------------------------- On März 27, 2016, 2:22 nachm., Sandro Knauß wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127462/ > ----------------------------------------------------------- > > (Updated März 27, 2016, 2:22 nachm.) > > > Review request for KDE Frameworks and Matthew Dawson. > > > Repository: kconfig > > > Description > ------- > > Inside desktop files we want to reach also data, cache and config home > to create files inside these directories. > > > Diffs > ----- > > autotests/kconfigtest.h be0a17ea66fbca989a53c68481c4252c9546dd45 > autotests/kconfigtest.cpp e92197f3be57ead47b70ca5d040474e7a554c416 > docs/options.md c7a6c061b700fd7a23b5dd1628cd22a18dec79da > src/core/kconfig.cpp 07fa6f552c61c52cc1dd64a1c5fb0e2f00873d50 > > Diff: https://git.reviewboard.kde.org/r/127462/diff/ > > > Testing > ------- > > Adding tests for XDG_*_HOME variables. > > > Thanks, > > Sandro Knauß > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
