----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127462/#review93914 -----------------------------------------------------------
It's a bit of a stretch to say that the XDG base dir spec says that env vars in config files and desktop files should work even if they are not set :) First, because support for env vars in desktop files ([$e]) is a KDE extension IIRC, and secondly because the base dir spec only gives default values for these locations, while [$e] was strictly supposed to be about env var expansion. This being said, I see no harm in extending that to support the default values as if they were set in the env var. Just the commit log should be a bit more like "add a feature" than "the spec tells us to do this". autotests/kconfigtest.cpp (line 511) <https://git.reviewboard.kde.org/r/127462/#comment63968> noeol was supposed to be the line with no EOL. Leave it as the last position. autotests/kconfigtest.cpp (line 536) <https://git.reviewboard.kde.org/r/127462/#comment63969> Why? On my system this wouldn't pass. If you want to make sure it's empty, use qunsetenv. autotests/kconfigtest.cpp (line 538) <https://git.reviewboard.kde.org/r/127462/#comment63971> writableLocaion, not displayName. This shows the limitations of a unittest that uses the same code in the code and in the test. If both are wrong, the test still passes :-) src/core/kconfig.cpp (line 226) <https://git.reviewboard.kde.org/r/127462/#comment63970> displayName?? You want writableLocation here. - David Faure On March 22, 2016, 3:23 p.m., Sandro Knauß wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127462/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 3:23 p.m.) > > > Review request for KDE Frameworks and Matthew Dawson. > > > Repository: kconfig > > > Description > ------- > > According to freedesktop specification XDG_*_HOME env varaible should be > replaced, if they are not setted with default values. > > https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html > > as qgetenv only calls getenv, so no path is traslated to it default values. > So we have to add this replacement manually. This would help to use > XDG_*_HOME more often in configfiles. > > > Diffs > ----- > > autotests/kconfigtest.cpp e92197f3be57ead47b70ca5d040474e7a554c416 > src/core/kconfig.cpp 07fa6f552c61c52cc1dd64a1c5fb0e2f00873d50 > > Diff: https://git.reviewboard.kde.org/r/127462/diff/ > > > Testing > ------- > > Adding tests for XDG_*_HOME variables. > > > Thanks, > > Sandro Knauß > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
