----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127215/#review92874 -----------------------------------------------------------
src/sycoca/kbuildsycoca.cpp (line 236) <https://git.reviewboard.kde.org/r/127215/#comment63343> foreach like you did above? src/sycoca/ksycocadict.cpp (line 316) <https://git.reviewboard.kde.org/r/127215/#comment63344> Maybe it's better to leave the * there, as it makes it more clear that it's an output argument. - Aleix Pol Gonzalez On Feb. 29, 2016, 1:43 a.m., Nick Shaforostoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127215/ > ----------------------------------------------------------- > > (Updated Feb. 29, 2016, 1:43 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kservice > > > Description > ------- > > Changes are mostly related to containers/iterators, but there are also few > QString related optimizations > > note that i have made a switch from QLinkedList to just QList because it > performs better for T=<void*> > also i have changed QStringList to QSet<QString> in one place to make the > code run faster > > > Diffs > ----- > > src/sycoca/kbuildmimetypefactory.cpp 340f76a > src/sycoca/kbuildservicefactory.cpp a74f2e8 > src/sycoca/kbuildsycoca.cpp e99e906 > src/sycoca/kmimeassociations.cpp 9423b27 > src/sycoca/ksycocadict.cpp f33d01a > src/sycoca/ksycocafactory.cpp e410581 > > Diff: https://git.reviewboard.kde.org/r/127215/diff/ > > > Testing > ------- > > all tests pass, except kmimeassociationstest (fakeApplicationService is > NULL), but it fails also without my changes > > > Thanks, > > Nick Shaforostoff > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
